ME-41:Fix windows build error for invalid URI - #45
Conversation
|
@wikumChamith please review this |
|
@sudhanshu-raj can you share more details on this error, like the full error logs? You can add them to the JIRA ticket. |
Attached on the JIRA ticket . |
|
@sudhanshu-raj can you fix this merge conflict |
aa3998e to
6943372
Compare
Done ! |
|
@sudhanshu-raj The build is failing due to a code formatting error. Could you please fix it and let us know? |
# Conflicts: # api/src/test/resources/TestingApplicationContext.xml
6943372 to
d042d33
Compare
Ahh didn't notice, my bad, fixed |
wikumChamith
left a comment
wikumChamith
left a comment
There was a problem hiding this comment.
@sudhanshu-raj Actually, this is a temporary workaround. We need to fix the error at the source. Can you create a PR in the initializer module with the fix?
4 participants
Description of what I changed
Resolve the build error for Windows due to the Initializer's
InitializerMessageSourceclasspath scanning which results in invalid URI syntax error. This module not uses any message source from Initializer module so it's safe to skip scanning their classpath to fetch message properties.Issue I worked on
see https://openmrs.atlassian.net/browse/ME-41
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master